[webkit-reviews] review granted: [Bug 126609] [EFL][WK2] Fix failing ewk_view_page_contents_get() API test : [Attachment 220573] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 126609: [EFL][WK2] Fix failing ewk_view_page_contents_get() API test
https://bugs.webkit.org/show_bug.cgi?id=126609

Attachment 220573: Patch
https://bugs.webkit.org/attachment.cgi?id=220573&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220573&action=review


LGTM except for some minor comments.

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:217
> +	   // Layout tests, so checking the amount of bytes is enough.

Layout -> layout

> Source/WebKit2/UIProcess/API/efl/tests/test_ewk2_view.cpp:218
> +	   Eina_File* pFile = eina_file_open(TEST_RESOURCES_DIR
"/resultMHTML.mht", false);

It looks pFile is not EFL or WebKit variable naming style. How about using 'f'
or 'file' for it ?