[webkit-reviews] review granted: [Bug 126552] Marking should be generational : [Attachment 220569] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 126552: Marking should be generational
https://bugs.webkit.org/show_bug.cgi?id=126552

Attachment 220569: Patch
https://bugs.webkit.org/attachment.cgi?id=220569&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220569&action=review


r=me

> Source/JavaScriptCore/heap/MarkedBlock.h:76
> -	   static const size_t atomSize = 8; // bytes
> +	   static const size_t atomSize = 16; // bytes

Why 16 byte atoms? Won't this mean that 24 byte objects grow to be 32 bytes?
Seems like a memory use regression.