[webkit-reviews] review granted: [Bug 126607] Web Inspector: Remove leftover 'device metrics' code : [Attachment 220571] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 7 17:35:48 PST 2014


Joseph Pecoraro <joepeck at webkit.org> has granted Seokju Kwon
<seokju at webkit.org>'s request for review:
Bug 126607: Web Inspector: Remove leftover 'device metrics' code
https://bugs.webkit.org/show_bug.cgi?id=126607

Attachment 220571: Patch
https://bugs.webkit.org/attachment.cgi?id=220571&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220571&action=review


r=me, one nit

> Source/WebCore/rendering/TextAutosizer.cpp:119
>      if (windowInfo.windowSize.isEmpty()) {
> -	   bool includeScrollbars =
!InspectorInstrumentation::shouldApplyScreenWidthOverride(&mainFrame);
> -	   windowInfo.windowSize =
mainFrame.view()->unscaledVisibleContentSize(includeScrollbars ?
ScrollableArea::IncludeScrollbars : ScrollableArea::ExcludeScrollbars);
> +	   windowInfo.windowSize =
mainFrame.view()->unscaledVisibleContentSize(ScrollableArea::IncludeScrollbars)
;
>      }

Style: Remove the braces for this if now that it is s single statement.


More information about the webkit-reviews mailing list