[webkit-reviews] review granted: [Bug 126536] TileController can fail to receive exposedRect from the drawing area if set at the wrong time : [Attachment 220568] patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 126536: TileController can fail to receive exposedRect from the drawing
area if set at the wrong time
https://bugs.webkit.org/show_bug.cgi?id=126536

Attachment 220568: patch
https://bugs.webkit.org/attachment.cgi?id=220568&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220568&action=review


> Source/WebCore/page/FrameView.h:449
> +    void setExposedRect(FloatRect);
> +    FloatRect exposedRect() const { return m_exposedRect; }

Please add comments to say what "exposed" means and why it's different from
visibleContentRect etc.

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:55
> +    , m_exposedRect(FloatRect::infiniteRect())

Sad that this exposedRect only makes sense for the main TileController.