[webkit-reviews] review granted: [Bug 126598] Web Inspector: Move InjectedScript classes into JavaScriptCore : [Attachment 220562] [PATCH] Part 5: Move InjectedScript classes into JavaScriptCore
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Tue Jan 7 15:50:07 PST 2014
Timothy Hatcher <timothy at apple.com> has granted Joseph Pecoraro
<joepeck at webkit.org>'s request for review:
Bug 126598: Web Inspector: Move InjectedScript classes into JavaScriptCore
https://bugs.webkit.org/show_bug.cgi?id=126598
Attachment 220562: [PATCH] Part 5: Move InjectedScript classes into
JavaScriptCore
https://bugs.webkit.org/attachment.cgi?id=220562&action=review
------- Additional Comments from Timothy Hatcher <timothy at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220562&action=review
> Source/JavaScriptCore/inspector/InjectedScriptManager.cpp:163
> + auto it1 = m_idToInjectedScript.find(it->value);
Not new, but it1 is gross. injectedScriptIterator?
More information about the webkit-reviews
mailing list