[webkit-reviews] review granted: [Bug 40382] HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected Directory : [Attachment 220495] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 40382: HTML5 video tag Does Not Load in Apache htaccess/htpasswd Protected
Directory
https://bugs.webkit.org/show_bug.cgi?id=40382

Attachment 220495: Patch
https://bugs.webkit.org/attachment.cgi?id=220495&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220495&action=review


> LayoutTests/http/tests/media/resources/video-auth.php:3
> +    $ua = $_SERVER["HTTP_USER_AGENT"];

Nit: this doesn't seem to be used.

> LayoutTests/http/tests/media/video-auth.html:22
> +		   var frame = document.createElement('iframe');
> +		   frame.width = 0;
> +		   frame.height = 0;
> +		   frame.addEventListener('load', function () {

This is odd, is it using the iframe 'load' event instead of setTimeout()?