[webkit-reviews] review granted: [Bug 126093] Repatch write barrier slow path call doesn't align the stack in the presence of saved registers : [Attachment 220535] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 126093: Repatch write barrier slow path call doesn't align the stack in the
presence of saved registers
https://bugs.webkit.org/show_bug.cgi?id=126093

Attachment 220535: Patch
https://bugs.webkit.org/attachment.cgi?id=220535&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220535&action=review


r=me

> Source/JavaScriptCore/jit/Repatch.cpp:798
> +    unsigned desiredAlignment = 16;

Please use StackAlignment.h instead.

> Source/JavaScriptCore/jit/Repatch.cpp:897
>  #if ENABLE(GGC)
> -    MacroAssembler::Call writeBarrierOperation = writeBarrier(stubJit,
baseGPR, scratchGPR1, scratchGPR2, allocator);
> +    MacroAssembler::Call writeBarrierOperation = writeBarrier(stubJit,
baseGPR, scratchGPR1, scratchGPR2, callFrameRegister, allocator);
>  #endif

For #ifdefs like this, I prefer to make the call site unconditional, and make
the implementation of writeBarrier() conditional on #ENABLE(GGC). That removes
distractions from the code.