[webkit-reviews] review granted: [Bug 126568] Move RenderObject::firstLineBlock() to RenderElement. : [Attachment 220502] Patch

[bugzilla-daemon at webkit.org]

Antti Koivisto <koivisto at iki.fi> has granted Andreas Kling <akling at apple.com>'s
request for review:
Bug 126568: Move RenderObject::firstLineBlock() to RenderElement.
https://bugs.webkit.org/show_bug.cgi?id=126568

Attachment 220502: Patch
https://bugs.webkit.org/attachment.cgi?id=220502&action=review

------- Additional Comments from Antti Koivisto <koivisto at iki.fi>
View in context: https://bugs.webkit.org/attachment.cgi?id=220502&action=review


> Source/WebCore/rendering/RenderElement.h:145
> +    // Obtains the nearest enclosing block (including this block) that
contributes a first-line style to our inline children.
> +    virtual RenderBlock* firstLineBlock();

Since this is null except for RenderBlocks this virtual shouldn't really
exists. It would be good to eventually tighten the call sites to check and cast
to RenderBlock.