[webkit-reviews] review requested: [Bug 117275] [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run launcher : [Attachment 220510] Patch

[bugzilla-daemon at webkit.org]

Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 117275: [GTK][EFL] Use function jhbuildWrapperPrefixIfNeeded to run
launcher
https://bugs.webkit.org/show_bug.cgi?id=117275

Attachment 220510: Patch
https://bugs.webkit.org/attachment.cgi?id=220510&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
(In reply to comment #5)
> OK, I think the reason is because the function
> jhbuildWrapperPrefixIfNeeded() tests first if the jhbuildPath
> exists. If not, returns an empty path.

That function returns an empty list, so when do you

($launcherPath, my @args) = jhbuildWrapperPrefixIfNeeded();

you're turning $launcherPath into an undefined variable, which you
then are trying to exec.

I reworked the script a bit, now there's a scalar variable for the
launcher command, an array for the jhbuild wrapper and its options and
@ARGV, with the command-line parameters set by the user, which I
decided to leave untouched.

Hope it's a bit clearer now.