[webkit-reviews] review denied: [Bug 94488] --disable-dependency-tracking causes build failure due to missing directories : [Attachment 193474] Patch making --disable-dependency-tracking work

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has denied Tobias Mueller
<tobiasmue at gnome.org>'s request for review:
Bug 94488: --disable-dependency-tracking causes build failure due to missing
directories
https://bugs.webkit.org/show_bug.cgi?id=94488

Attachment 193474: Patch making --disable-dependency-tracking work
https://bugs.webkit.org/attachment.cgi?id=193474&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=193474&action=review


Thanks for the patch! I think the changes are OK, just a few changelog style
issues that need fixing.

> Source/WebCore/ChangeLog:6
> +	   Autotools build fix: Ensure output directory existing
> +	   before generating DerivedSources. This allows for
> +	   --disable-dependency-tracking to be run.
> +	   https://bugs.webkit.org/show_bug.cgi?id=94488

This should be the bug's title, not the change description, change description
should go bellow the Reviewed by line.

> Source/WebCore/ChangeLog:10
> +	   No new tests (OOPS!).

You should remove this line.

> Source/WebCore/ChangeLog:14
> +	   * GNUmakefile.am:
> +	       Added new target DerivedSources/ANGLE which is a directory to be

> +	       created

You should start the change descrtiption detail right after the colon, lines do
not need to be split at 80 columns, these could be a single line.