[webkit-reviews] review granted: [Bug 125855] [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE : [Attachment 220218] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Tue Jan 7 02:12:36 PST 2014


Mario Sanchez Prada <mario at webkit.org> has granted Krzysztof Czech
<k.czech at samsung.com>'s request for review:
Bug 125855: [ATK] Expose aria-checked mixed state as ATK_STATE_INDETERMINATE
https://bugs.webkit.org/show_bug.cgi?id=125855

Attachment 220218: patch
https://bugs.webkit.org/attachment.cgi?id=220218&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Thanks for the patch, Krzysztof. It looks good to me although I just realized
you need to provide empty functions for the win and the ios ports too, and add
the new test to win/TestExpectations.

Setting r+ now, but please consider those two things before landing.


More information about the webkit-reviews mailing list