[webkit-reviews] review granted: [Bug 126556] Heap::collect shouldn't be responsible for sweeping : [Attachment 220488] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 126556: Heap::collect shouldn't be responsible for sweeping
https://bugs.webkit.org/show_bug.cgi?id=126556

Attachment 220488: Patch
https://bugs.webkit.org/attachment.cgi?id=220488&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220488&action=review


r=me

> Source/JavaScriptCore/heap/Heap.cpp:734
> +    SamplingRegion samplingRegion("Garbage Collection: Sweeping");

Sampling region should probably go before DelayedReleaseScope, so we sample all
destructor time, including delayed destructor time.