[webkit-reviews] review granted: [Bug 126536] TileController can fail to receive exposedRect from the drawing area if set at the wrong time : [Attachment 220478] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 126536: TileController can fail to receive exposedRect from the drawing
area if set at the wrong time
https://bugs.webkit.org/show_bug.cgi?id=126536

Attachment 220478: patch
https://bugs.webkit.org/attachment.cgi?id=220478&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220478&action=review


> Source/WebCore/ChangeLog:3
> +	   TileController can fail to receive exposedRect from the drawing area
if if set at the wrong time

if if.

> Source/WebCore/platform/graphics/GraphicsLayerClient.h:100
> +    virtual FloatRect exposedRect() const { return FloatRect(); }

I think this should return the infinite rect?

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:308
> +void TileController::exposedRectChanged()

DidChange?

> Source/WebKit2/WebProcess/WebPage/mac/TiledCoreAnimationDrawingArea.mm:378
> +    FloatRect visibleRect = m_rootLayer.get().frame;

[m_rootLayer frame];