[webkit-reviews] review granted: [Bug 126550] CStack Branch: Disable JIT stack alignment check for ARM64 : [Attachment 220474] Patch

[bugzilla-daemon at webkit.org]

Mark Lam <mark.lam at apple.com> has granted Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 126550: CStack Branch: Disable JIT stack alignment check for ARM64
https://bugs.webkit.org/show_bug.cgi?id=126550

Attachment 220474: Patch
https://bugs.webkit.org/attachment.cgi?id=220474&action=review

------- Additional Comments from Mark Lam <mark.lam at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220474&action=review


r=me with comment fix.

> Source/JavaScriptCore/ChangeLog:8
> +	   Disabled the compilation of the body of checkStackPointerAlignment
for ARM64.

Can you put your bug comment here instead?  The bug comment said, "Since ARM64
enforces strict stack alignment, the need for checkStackPointerAlignment() is
not needed.  Also, the implementation of checkStackPointerAlignment() would
need to be reworked given the limits on the operations that can be done with
the stack pointer register in ARM64.  Therefore checkStackPointerAlignment()
should be conditionally disabled for ARM64."  I think your bug comment does a
good job of explaining why we needed this change.