[webkit-reviews] review granted: [Bug 126532] Add new files for UI-side scrolling : [Attachment 220445] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Simon Fraser (smfr)
<simon.fraser at apple.com>'s request for review:
Bug 126532: Add new files for UI-side scrolling
https://bugs.webkit.org/show_bug.cgi?id=126532

Attachment 220445: Patch
https://bugs.webkit.org/attachment.cgi?id=220445&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220445&action=review


> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingCoordinatorProxy.h:49
> +    explicit RemoteScrollingCoordinatorProxy(WebPageProxy*);

Reference?

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h:41
> +

Please get rid of this newline.

> Source/WebKit2/UIProcess/Scrolling/RemoteScrollingTree.h:46
> +    virtual bool isRemoteScrollingTree() const OVERRIDE { return true; }
> +
> +    virtual EventResult tryToHandleWheelEvent(const
WebCore::PlatformWheelEvent&) OVERRIDE;

I'd get rid of this newline.

> Source/WebKit2/WebProcess/Scrolling/RemoteScrollingCoordinator.h:68
> +    // CoreIPC::MessageReceiver

Should just be IPC::.

> Source/WebKit2/WebProcess/Scrolling/RemoteScrollingCoordinator.messages.in:24

> +    ScrollPositionChangedForNode(uint64_t nodeID, WebCore::FloatPoint
scrollPosition);

Maybe DidChange instead of Changed?