[webkit-reviews] review denied: [Bug 126377] Web Inspector: Frontend has no support for memory : [Attachment 220211] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has denied Seokju Kwon
<seokju at webkit.org>'s request for review:
Bug 126377: Web Inspector: Frontend has no support for memory
https://bugs.webkit.org/show_bug.cgi?id=126377

Attachment 220211: Patch
https://bugs.webkit.org/attachment.cgi?id=220211&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
Although the frontend does not use it, if we did would getDOMCounters be
correct? It looks like it would be. Maybe instead of removing this domain we
could make use of that data.

That said, "MemoryBlock" doesn't look like it is used at all.

Memory instrumentation is certainly something we will want to add to the
inspection. We will probably reimplement it anyways, and if we do go through
and remove this implementation here we can dig up this old code.

For starters, r- this code now anyways because if we did remove it there is
even more code that we should remove (the counter tracking itself!):

platform/ThreadGlobalData.h
43:    class ThreadLocalInspectorCounters;
70:	   ThreadLocalInspectorCounters& inspectorCounters() { return
*m_inspectorCounters; }
91:	   OwnPtr<ThreadLocalInspectorCounters> m_inspectorCounters;

inspector/InspectorCounters.cpp
61:    return threadGlobalData().inspectorCounters();

bindings/js/JSEventListener.cpp
55:   
ThreadLocalInspectorCounters::current().incrementCounter(ThreadLocalInspectorCo
unters::JSEventListenerCounter);
62:   
ThreadLocalInspectorCounters::current().decrementCounter(ThreadLocalInspectorCo
unters::JSEventListenerCounter);