[webkit-reviews] review granted: [Bug 126369] Web Inspector: Remove support for FileSystem in Frontend. : [Attachment 220199] Patch

[bugzilla-daemon at webkit.org]

Joseph Pecoraro <joepeck at webkit.org> has granted Seokju Kwon
<seokju at webkit.org>'s request for review:
Bug 126369: Web Inspector: Remove support for FileSystem in Frontend.
https://bugs.webkit.org/show_bug.cgi?id=126369

Attachment 220199: Patch
https://bugs.webkit.org/attachment.cgi?id=220199&action=review

------- Additional Comments from Joseph Pecoraro <joepeck at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220199&action=review


r+ but there is more that you can delete! There are corresponding
InspectorFrontendHost APIs which I think can be removed.

InspectorFrontendClient.h
78:    virtual bool supportsFileSystems() = 0;
79:    virtual void requestFileSystems() = 0;
80:    virtual void addFileSystem() = 0;
81:    virtual void removeFileSystem(const String& fileSystemPath) = 0;

InspectorFrontendClientLocal.h
79:    virtual bool supportsFileSystems() { return false; }
80:    virtual void requestFileSystems() { }
81:    virtual void addFileSystem() { }
82:    virtual void removeFileSystem(const String&) { }

InspectorFrontendHost.cpp
316:bool InspectorFrontendHost::supportsFileSystems()
319:	    return m_client->supportsFileSystems();
323:void InspectorFrontendHost::requestFileSystems()
326:	    m_client->requestFileSystems();
329:void InspectorFrontendHost::addFileSystem()
332:	    m_client->addFileSystem();
335:void InspectorFrontendHost::removeFileSystem(const String& fileSystemPath)
338:	    m_client->removeFileSystem(fileSystemPath);

InspectorFrontendHost.h
87:    bool supportsFileSystems();
88:    void requestFileSystems();
89:    void addFileSystem();
90:    void removeFileSystem(const String& fileSystemPath);

> Source/WebInspectorUI/UserInterface/InspectorWebBackendCommands.js:-162
> -// FileSystem.

I would suggest also deleting domain from Legacy protocols as well:

    {
	"domain": "FileSystem",
	...
    },

For the reasons mentioned earlier in comments on other bugs (we don't plan to
support it, and don't want naming conflicts if we add something in the future.
We aren't keeping these pristine anyways).

    Source/WebInspectorUI/Versions/Inspector-iOS-6.0.json
    Source/WebInspectorUI/Versions/Inspector-iOS-7.0.json

Then rerun update-InspectorBackendCommands which will update
UserInterface/Legacy/*/InspectorWebBackendCommands.js