[webkit-reviews] review denied: [Bug 126055] #defined constants should use all uppercase names with words separated by underscores. : [Attachment 220418] patch

[bugzilla-daemon at webkit.org]

Alexey Proskuryakov <ap at webkit.org> has denied Gergő Balogh
<gbalogh.u-szeged at partner.samsung.com>'s request for review:
Bug 126055: #defined constants should use all uppercase names with words
separated by underscores.
https://bugs.webkit.org/show_bug.cgi?id=126055

Attachment 220418: patch
https://bugs.webkit.org/attachment.cgi?id=220418&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=220418&action=review


> Tools/Scripts/webkitpy/style/checkers/cpp.py:2726
> +	   if not match(r'^[A-Z_]+$', name):

This expression doesn't allow for digits, which may be legitimately present in
macro names.