[webkit-reviews] review granted: [Bug 126506] [JS] Implement Promise.race() : [Attachment 220404] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Sun Jan 5 19:44:35 PST 2014


Oliver Hunt <oliver at apple.com> has granted Sam Weinig <sam at webkit.org>'s
request for review:
Bug 126506: [JS] Implement Promise.race()
https://bugs.webkit.org/show_bug.cgi?id=126506

Attachment 220404: Patch
https://bugs.webkit.org/attachment.cgi?id=220404&action=review

------- Additional Comments from Oliver Hunt <oliver at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220404&action=review


> Source/JavaScriptCore/runtime/JSPromiseConstructor.cpp:383
> +	   if (JSValue::strictEqual(exec, next, vm.iterationTerminator.get()))

should just do a value compare here


More information about the webkit-reviews mailing list