[webkit-reviews] review granted: [Bug 126468] [WebGL] CGLPixelFormat should specify SampleBuffer and Sample count when using MSAA : [Attachment 220348] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 126468: [WebGL] CGLPixelFormat should specify SampleBuffer and Sample count
when using MSAA
https://bugs.webkit.org/show_bug.cgi?id=126468

Attachment 220348: Patch
https://bugs.webkit.org/attachment.cgi?id=220348&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220348&action=review


> Source/WebCore/platform/graphics/mac/GraphicsContext3DMac.mm:145
> +    bool useMultisampling = m_attrs.antialias;
> +    
> +    setPixelFormat(attribs, 32, 32, !attrs.forceSoftwareRenderer, true,
false, useMultisampling);

This preserves our existing behaviour to request supersampling when
anti-aliasing was false. I guess that's ok.