[webkit-reviews] review granted: [Bug 126457] [iOS] [WK2] TileController creates all tiles on first paint, making it slow and consuming lots of memory : [Attachment 220336] fix the title for sam

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Tim Horton
<thorton at apple.com>'s request for review:
Bug 126457: [iOS] [WK2] TileController creates all tiles on first paint, making
it slow and consuming lots of memory
https://bugs.webkit.org/show_bug.cgi?id=126457

Attachment 220336: fix the title for sam
https://bugs.webkit.org/attachment.cgi?id=220336&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220336&action=review


> Source/WebKit2/UIProcess/API/ios/WKContentView.h:68
> +- (void)didLiveScrollTo:(CGPoint)contentOffset;

Hmm, we don't really use the term "live scroll" anywhere else.

> Source/WebKit2/UIProcess/API/ios/WKContentView.mm:141
> +   
_page->viewExposedRectChanged(FloatRect(_page->viewExposedRect().location(),
FloatSize(size)), true);

No idea what true means.

> Source/WebKit2/UIProcess/WebPageProxy.cpp:4398
> +void WebPageProxy::viewExposedRectChanged(const FloatRect& exposedRect, bool
clipsToExposedRect)

Please replace clipsToExposedRect with an enum