[webkit-reviews] review granted: [Bug 126440] [MediaControls][iOS] Enable JavaScript Media Controls on iOS. : [Attachment 220321] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Jer Noble
<jer.noble at apple.com>'s request for review:
Bug 126440: [MediaControls][iOS] Enable JavaScript Media Controls on iOS.
https://bugs.webkit.org/show_bug.cgi?id=126440

Attachment 220321: Patch
https://bugs.webkit.org/attachment.cgi?id=220321&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220321&action=review


> Source/WebCore/DerivedSources.make:850
> +ifeq ($(WTF_PLATFORM_IOS),1)

Nit: there should be a space after the comma.

> Source/WebCore/DerivedSources.make:870
> +ifeq ($(WTF_PLATFORM_IOS),1)

Ditto.

> Source/WebCore/Modules/mediacontrols/mediaControlsiOS.css:185
> +    /* rotateZ() forces the layer into compositing mode.
> +    Slider thumbs are small, so forcing a compositing layer is inexpensive,
> +	  and it keeps the slider from having to repaint while sliding. */

Nit: good comment, but strange indentation.