[webkit-reviews] review denied: [Bug 126422] CStack Branch: slowPathFor in ThunkGenerators.cpp fail to compile : [Attachment 220287] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 3 10:14:36 PST 2014


Filip Pizlo <fpizlo at apple.com> has denied Michael Saboff <msaboff at apple.com>'s
request for review:
Bug 126422: CStack Branch: slowPathFor in ThunkGenerators.cpp fail to compile
https://bugs.webkit.org/show_bug.cgi?id=126422

Attachment 220287: Patch
https://bugs.webkit.org/attachment.cgi?id=220287&action=review

------- Additional Comments from Filip Pizlo <fpizlo at apple.com>
I really don't like the use of these pragmas.  Is this because slowPathFor
calls a function marked NORETURN?  If so, remove NORETURN from that function. 
Can't remove NORETURN from a function because it uses CRASH() or
RELEASE_ASSERT_NOT_REACHED()?  In that case, just use
UNREACHABLE_FOR_PLATFORM() instead.


More information about the webkit-reviews mailing list