[webkit-reviews] review requested: [Bug 88407] WebKit-GTK 1.8.1 does not build on OS X 10.7 : [Attachment 220304] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Jan 3 08:13:47 PST 2014


Alberto Garcia <berto at igalia.com> has asked  for review:
Bug 88407: WebKit-GTK 1.8.1 does not build on OS X 10.7
https://bugs.webkit.org/show_bug.cgi?id=88407

Attachment 220304: Patch
https://bugs.webkit.org/attachment.cgi?id=220304&action=review

------- Additional Comments from Alberto Garcia <berto at igalia.com>
(In reply to comment #5)
> $(AM_V_at)($(foreach idl, $(dom_binding_idls), echo $(idl) &&) echo -n) >>
$(idl_files_list)

> Hum, not sure. My shell programming skills are rusty :) Is that echo
> -n call really needed?

That's because you need a final command after the last &&.

I think we can replace 'echo -n' with 'true' or ':'.


More information about the webkit-reviews mailing list