[webkit-reviews] review canceled: [Bug 125583] [SOUP] Port custom URI schemes implementation to CUSTOM PROTOCOLS : [Attachment 220164] Patch

[bugzilla-daemon at webkit.org]

Carlos Garcia Campos <cgarcia at igalia.com> has canceled Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 125583: [SOUP] Port custom URI schemes implementation to CUSTOM PROTOCOLS
https://bugs.webkit.org/show_bug.cgi?id=125583

Attachment 220164: Patch
https://bugs.webkit.org/attachment.cgi?id=220164&action=review

------- Additional Comments from Carlos Garcia Campos <cgarcia at igalia.com>
Patch updated to not use any soup #ifdef in CustomProtocolManager header file.
In the end I've added a CustomProtocolManagerImpl with all the soup specific
implementation. This leaves CustomProtocolManagerSoup.cpp mostly
cross-platform, so if mac switches to use their own CustomProtocolManagerImpl
to remove also the mac #ifdefs, we could remove CustomProtocolManagerSoup.cpp
and CustomProtocolManagerMac.cpp an use a common implementation for the
cross-platform bits. I've also changed some uses of OwnPtr to use
std::unique_ptr instead.