[webkit-reviews] review granted: [Bug 126417] VibrationPattern should allocate an single vector instance for single integer input : [Attachment 220281] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 126417: VibrationPattern should allocate an single vector instance for
single integer input
https://bugs.webkit.org/show_bug.cgi?id=126417

Attachment 220281: Patch
https://bugs.webkit.org/attachment.cgi?id=220281&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220281&action=review


LGTM

> Source/WebCore/Modules/vibration/NavigatorVibration.cpp:43
> +    return NavigatorVibration::vibrate(navigator, VibrationPattern(1,
time));

Good catch ! We have missed this one so far.