[webkit-reviews] review granted: [Bug 126249] [EFL][WK2] Remove defaultPageGroupIdentifier not to make the confusion : [Attachment 220039] Patch

[bugzilla-daemon at webkit.org]

Gyuyoung Kim <gyuyoung.kim at samsung.com> has granted Ryuan Choi
<ryuan.choi at samsung.com>'s request for review:
Bug 126249: [EFL][WK2] Remove defaultPageGroupIdentifier not to make the
confusion
https://bugs.webkit.org/show_bug.cgi?id=126249

Attachment 220039: Patch
https://bugs.webkit.org/attachment.cgi?id=220039&action=review

------- Additional Comments from Gyuyoung Kim <gyuyoung.kim at samsung.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220039&action=review


>>>> Source/WebKit2/ChangeLog:9
>>>> +	      but the identifiers of page groups will be same as
"defaultPageGroupIdentifier" when passed 0 or "".
>>> 
>>> How will the identifiers be same with "defaultPageGroupIdentifier" when
passing null ?
>> 
>> The identifier of WebPageGroup is just what user passed or generated one if
user passed empty string.
>> But, our previous logic only passed "defaultPageGroupIdentifier" when we
passed empty string.
>> 
>> In fact, WebPageGroup uses pageGroupID(generated one) and identifier (string
which user passed).
> 
> If the same identifier is passed, WebCore's page get same page group
identifier even a new WebPageGroup is created.
> 
> WebPage.cpp
> m_page->setGroupName(m_pageGroup->identifier());
> 
> The reason I added "defaultPageGroupIdentifier" was to make pages have same
group identifier even though developer did not set the identifier.
> But it would be better to remove this default identifier because it conflict
the behavior of WebPageGroup.

If WebPageGroup already support to generate an unique identifier when passing
null as argument, I agree to remove the default identifier.