[webkit-reviews] review granted: [Bug 126397] [GTK] Switch from WTF::Function to std::function in WebProcessTest : [Attachment 220244] Patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Zan Dobersek
<zandobersek at gmail.com>'s request for review:
Bug 126397: [GTK] Switch from WTF::Function to std::function in WebProcessTest
https://bugs.webkit.org/show_bug.cgi?id=126397

Attachment 220244: Patch
https://bugs.webkit.org/attachment.cgi?id=220244&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220244&action=review


> Source/WebKit2/ChangeLog:9
> +	   following the effor of using STL concepts where possible.

Effort.

(This is great btw, I'd really like to get rid of WTF::Function). 

We usually put a space between the return type and the left parenthesis for
function types.

> Source/WebKit2/UIProcess/API/gtk/tests/WebProcessTest.h:37
> +    WebProcessTest::add(String::fromUTF8(TestName),
std::bind(&ClassName::create))

Do you even need std::bind here?