[webkit-reviews] review granted: [Bug 126411] [WebGL] Correct symbol lookup logic to handle 1-element arrays : [Attachment 220266] Patch

[bugzilla-daemon at webkit.org]

Dean Jackson <dino at apple.com> has granted Brent Fulgham <bfulgham at webkit.org>'s
request for review:
Bug 126411: [WebGL] Correct symbol lookup logic to handle 1-element arrays
https://bugs.webkit.org/show_bug.cgi?id=126411

Attachment 220266: Patch
https://bugs.webkit.org/attachment.cgi?id=220266&action=review

------- Additional Comments from Dean Jackson <dino at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220266&action=review


> Source/WebCore/html/canvas/WebGLRenderingContext.cpp:3179
> +		   String arrayBrackets = "[" + String::number(index) + "]";
> +		   String uniformName = info.name + arrayBrackets;

I guess we could do this in one line, although I always forget the optimisation
rules for string building.