[webkit-reviews] review denied: [Bug 126320] CStack: Need a separate stack limit for the JS stack and the C stack : [Attachment 220154] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has denied Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 126320: CStack: Need a separate stack limit for the JS stack and the C
stack
https://bugs.webkit.org/show_bug.cgi?id=126320

Attachment 220154: the patch.
https://bugs.webkit.org/attachment.cgi?id=220154&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
This patch looks way too over-engineered.

There doesn't need to be a chunk-based stack limit per VM entry. That's also
likely to be wrong, since we need to account for intermediate C stack usage by
the VM.

This patch should be one line of code that puts a call to "std::max" around our
existing calculation for stack bounds. That's all that's required to prevent
runaway recursion.