[webkit-reviews] review granted: [Bug 126334] CStack: Introduce tracking of the top VMEntryScope. : [Attachment 220151] the patch.

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Lam <mark.lam at apple.com>'s
request for review:
Bug 126334: CStack: Introduce tracking of the top VMEntryScope.
https://bugs.webkit.org/show_bug.cgi?id=126334

Attachment 220151: the patch.
https://bugs.webkit.org/attachment.cgi?id=220151&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
r=me on this patch, but I think the overall approach should change, in this
way:

- VM should store the stack limits, as it does today
- VMEntryScope should set/reset the VM's stack limits, based on the current
thread's stack limit (and the JSStack size limit if using the CLoop)
- ErrorHandlingMode should be renamed to ErrorHandlingScope, and it should
set/reset the VM's stack limits just like VMEntryScope does, but with a more
lenient limit

That means:
- Entering an error handling scope shouldn't require a callback to VMEntryScope

- Entering an error handling scope shouldn't require a callback to JSStack
- JSStack should have an error handling mode
- JSStack::enable/disableErrorSTackReserve should not exist
- topEntryScope and prevTopEntryScope should not exist