[webkit-reviews] review granted: [Bug 126387] Refactor LLInt C stack frame munging helpers so that 32-bit code paths can use them : [Attachment 220232] the patch
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Thu Jan 2 13:13:18 PST 2014
Michael Saboff <msaboff at apple.com> has granted Filip Pizlo <fpizlo at apple.com>'s
request for review:
Bug 126387: Refactor LLInt C stack frame munging helpers so that 32-bit code
paths can use them
https://bugs.webkit.org/show_bug.cgi?id=126387
Attachment 220232: the patch
https://bugs.webkit.org/attachment.cgi?id=220232&action=review
------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220232&action=review
r=me with comments.
> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:278
> + elsif ARM64 or ARM or ARMv7 or ARMv7_TRADITIONAL or MIPS
> + pushLRAndFP
Only ARM64 has the pushLRAndFP / popLRAndFP pseudo ops. The other platforms
can push and pop individual registers. Therefore use the push cfr ; push lr
instructions for the non-ARM64 platforms.
> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:286
> + popLRAndFP
Ditto, except use pop lr ; pop cfr
> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:293
> + pushLRAndFP
Same comment as functionPrologue.
> Source/JavaScriptCore/llint/LowLevelInterpreter.asm:305
> + popLRAndFP
Same comment as functionEpilogue.
More information about the webkit-reviews
mailing list