[webkit-reviews] review granted: [Bug 126268] Merge didMoveOnscreen / page visibility to isVisible : [Attachment 220069] Fix

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Jan 2 11:53:18 PST 2014


Tim Horton <thorton at apple.com> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 126268: Merge didMoveOnscreen / page visibility to isVisible
https://bugs.webkit.org/show_bug.cgi?id=126268

Attachment 220069: Fix
https://bugs.webkit.org/attachment.cgi?id=220069&action=review

------- Additional Comments from Tim Horton <thorton at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220069&action=review


> Source/WebCore/page/Page.cpp:1223
> +    if (isVisible)
> +	   m_isPrerender = false;
> +
> +    if (isVisible) {

why are there two if() blocks with the same condition here?

> Source/WebCore/page/Page.cpp:1263
> +	   suspendScriptedAnimations();

space above here


More information about the webkit-reviews mailing list