[webkit-reviews] review requested: [Bug 126384] Proxied WebSockets with soup network backend : [Attachment 220225] Use new libsoup function to get a proxied GIOStream

[bugzilla-daemon at webkit.org]

Dirkjan Ochtman <dirkjan at ochtman.nl> has asked	for review:
Bug 126384: Proxied WebSockets with soup network backend
https://bugs.webkit.org/show_bug.cgi?id=126384

Attachment 220225: Use new libsoup function to get a proxied GIOStream
https://bugs.webkit.org/attachment.cgi?id=220225&action=review

------- Additional Comments from Dirkjan Ochtman <dirkjan at ochtman.nl>
Here's a WIP patch. I'd like for this to get a preliminary review. It probably
doesn't apply cleanly to current HEAD, but I'd like to gather some comments on
the design.

The patch relies on a new function in libsoup. That work is being tracked in
https://bugzilla.gnome.org/show_bug.cgi?id=721343. I was advised there that
extracting a GIOStream from libsoup made the most sense, which is why I also
replaced the GSocketConnection in SocketStreamHandle by a GIOStream. I'm aware
of the changes from bug 88094, so I'm also wondering how that would make sense
to integrate.