[webkit-reviews] review granted: [Bug 126368] Remove attachRenderTree : [Attachment 220198] patch

[bugzilla-daemon at webkit.org]

Andreas Kling <akling at apple.com> has granted Antti Koivisto <koivisto at iki.fi>'s
request for review:
Bug 126368: Remove attachRenderTree
https://bugs.webkit.org/show_bug.cgi?id=126368

Attachment 220198: patch
https://bugs.webkit.org/attachment.cgi?id=220198&action=review

------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220198&action=review


r=me

> Source/WebCore/html/shadow/InsertionPoint.h:100
> +inline InsertionPoint& toInsertionPoint(Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<InsertionPoint&>(node);
> +}
> +
> +inline const InsertionPoint& toInsertionPoint(const Node& node)
> +{
> +    ASSERT_WITH_SECURITY_IMPLICATION(node.isInsertionPoint());
> +    return static_cast<const InsertionPoint&>(node);
> +}

Could we replace this gunk with NODE_TYPE_CASTS(InsertionPoint) instead?