[webkit-reviews] review granted: [Bug 126359] Do less synchronous render tree construction : [Attachment 220188] patch

[bugzilla-daemon at webkit.org]

Anders Carlsson <andersca at apple.com> has granted Antti Koivisto
<koivisto at iki.fi>'s request for review:
Bug 126359: Do less synchronous render tree construction
https://bugs.webkit.org/show_bug.cgi?id=126359

Attachment 220188: patch
https://bugs.webkit.org/attachment.cgi?id=220188&action=review

------- Additional Comments from Anders Carlsson <andersca at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=220188&action=review


> Source/WebCore/html/HTMLInputElement.cpp:742
> +	   // This renderer and its children have quite different layouts and
styles depending on
> +	   // whether the speech button is visible or not. So we reset the
whole thing and recreate
> +	   // to get the right styles and layout.

Is this comment still accurate? Maybe tweak it to say something along the lines
of "when style recalc happens the render tree will be completely
reconstructed"?

> Source/WebCore/html/HTMLObjectElement.cpp:-389
> -    // FIXME: Style gets recalculated which is suboptimal.

Is this FIXME no longer relevant?