[webkit-reviews] review granted: [Bug 129476] StyledElement::attributeChanged shouldn't do any work when the attribute value didn't change : [Attachment 225446] Fixes the bug
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 28 22:23:23 PST 2014
Andreas Kling <akling at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 129476: StyledElement::attributeChanged shouldn't do any work when the
attribute value didn't change
https://bugs.webkit.org/show_bug.cgi?id=129476
Attachment 225446: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=225446&action=review
------- Additional Comments from Andreas Kling <akling at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225446&action=review
r=me
>> Source/WebCore/ChangeLog:8
>> + Exit early in attributeChanged when the attribute value didn't
change like r164856.
>
> This description doesn't quite match the code change, there is no early exit.
Yeah, could be worded better.
More information about the webkit-reviews
mailing list