[webkit-reviews] review granted: [Bug 129533] Fix WebKit2 build after r164890 : [Attachment 225528] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 28 20:41:24 PST 2014


Simon Fraser (smfr) <simon.fraser at apple.com> has granted Jinwoo Song
<jinwoo7.song at samsung.com>'s request for review:
Bug 129533: Fix WebKit2 build after r164890
https://bugs.webkit.org/show_bug.cgi?id=129533

Attachment 225528: Patch
https://bugs.webkit.org/attachment.cgi?id=225528&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225528&action=review


> Source/WebKit2/ChangeLog:9
> +	   but it is not used in non MAC or IOS port.

MAC -> Mac, IOS -> iOS

> Source/WebKit2/UIProcess/WebPageProxy.h:97
> +#if PLATFORM(MAC) || PLATFORM(IOS)

This should be #if PLATFORM(COCOA)


More information about the webkit-reviews mailing list