[webkit-reviews] review granted: [Bug 129520] Split UserActivity/CountedUserActivity : [Attachment 225510] Fix
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 28 18:20:25 PST 2014
Sam Weinig <sam at webkit.org> has granted Gavin Barraclough
<barraclough at apple.com>'s request for review:
Bug 129520: Split UserActivity/CountedUserActivity
https://bugs.webkit.org/show_bug.cgi?id=129520
Attachment 225510: Fix
https://bugs.webkit.org/attachment.cgi?id=225510&action=review
------- Additional Comments from Sam Weinig <sam at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225510&action=review
> Source/WebCore/platform/UserActivity.h:52
> + size_t m_started;
I think this should bool m_isActive;
> Source/WebKit2/WebProcess/WebPage/WebPage.cpp:2629
> + if
(store.getBoolValueForKey(WebPreferencesKey::pageVisibilityBasedProcessSuppress
ionEnabledKey()))
> + m_processSuppressionDisabledByWebPreference.stop();
> + else
> + m_processSuppressionDisabledByWebPreference.start();
FIX!!!!
More information about the webkit-reviews
mailing list