[webkit-reviews] review granted: [Bug 129471] [iOS][WK2] Pages with Graphics Layers cause giant tiling surfaces on zoom : [Attachment 225493] Patch

[bugzilla-daemon at webkit.org]

Simon Fraser (smfr) <simon.fraser at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 129471: [iOS][WK2] Pages with Graphics Layers cause giant tiling surfaces
on zoom
https://bugs.webkit.org/show_bug.cgi?id=129471

Attachment 225493: Patch
https://bugs.webkit.org/attachment.cgi?id=225493&action=review

------- Additional Comments from Simon Fraser (smfr) <simon.fraser at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225493&action=review


> Source/WebCore/ChangeLog:3
> +	   [iOS][WK2] Pages with Graphics Layers cause giant tiling surfaces on
zoom

"Pages with Graphics Layer" isn't accurate. I'd say "Pages using tiled
compositing layers allocate too many tiles on zoom" or something.

> Source/WebCore/platform/ScrollView.h:397
> +    // exposed rect and unobscuredRects. The two attributes should
eventually be merged.

between exposed....

> Source/WebCore/platform/graphics/ca/mac/TileController.mm:504
> +    // FIXME: ViewUpdateDispatcher could do an amazing job at computing
this.
> +    // In the meantime, just default to something good enough.

File a bug to track this, and reference it here.

> Source/WebCore/platform/ios/ScrollViewIOS.mm:131
> +    IntRect parentViewExtentContentRect =
parent->visibleExtentContentRect();
> +    IntRect selfExtentContentRect =
rootViewToContents(parentViewExtentContentRect);
> +    selfExtentContentRect.intersect(boundsRect());

Please add comment about better clipping by superviews.

> Source/WebKit2/WebProcess/WebPage/ios/WebPageIOS.mm:1649
> +    float floatBoundedScale = boundedScale;

Why not just use the double below?