[webkit-reviews] review requested: [Bug 129322] [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK). : [Attachment 225499] Revised patch to address review comment.
bugzilla-daemon at webkit.org
bugzilla-daemon at webkit.org
Fri Feb 28 15:28:00 PST 2014
Yongjun Zhang <yongjun_zhang at apple.com> has asked for review:
Bug 129322: [iOS] Download support by CFURLDownloadRef under USE(CFNETWORK).
https://bugs.webkit.org/show_bug.cgi?id=129322
Attachment 225499: Revised patch to address review comment.
https://bugs.webkit.org/attachment.cgi?id=225499&action=review
------- Additional Comments from Yongjun Zhang <yongjun_zhang at apple.com>
Main changes:
1) Fixed leak for resumeData in didFail; and adoptCF for CFURLDownloadRef
created on Download::startWithHandle.
2) Use a temporary variable BOOL instead of casting (bool*) to (BOOL*) in
decideDestinationWithSuggestedFilename.
3) Changed to use lambda for blocks passing into dispatchOnMainThread.
4) Some style fixes pointed out in reviewing comments.
More information about the webkit-reviews
mailing list