[webkit-reviews] review granted: [Bug 129472] [iOS][WK2] highlight rects should never big bigger than the view : [Attachment 225443] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 28 15:06:03 PST 2014


Enrica Casucci <enrica at apple.com> has granted Benjamin Poulain
<benjamin at webkit.org>'s request for review:
Bug 129472: [iOS][WK2] highlight rects should never big bigger than the view
https://bugs.webkit.org/show_bug.cgi?id=129472

Attachment 225443: Patch
https://bugs.webkit.org/attachment.cgi?id=225443&action=review

------- Additional Comments from Enrica Casucci <enrica at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225443&action=review


Looks good to me.

> Source/WebKit2/UIProcess/ios/WKContentViewInteraction.mm:296
> +static inline bool highlightedQuadsFitInRect(const Vector<FloatQuad>& quads,
const FloatRect& rect)

maybe isHighlightQuadSmaller ?


More information about the webkit-reviews mailing list