[webkit-reviews] review granted: [Bug 129427] Some small modernizing tweaks to the coding style guide : [Attachment 225374] Patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Fri Feb 28 10:08:50 PST 2014


Alexey Proskuryakov <ap at webkit.org> has granted Darin Adler <darin at apple.com>'s
request for review:
Bug 129427: Some small modernizing tweaks to the coding style guide
https://bugs.webkit.org/show_bug.cgi?id=129427

Attachment 225374: Patch
https://bugs.webkit.org/attachment.cgi?id=225374&action=review

------- Additional Comments from Alexey Proskuryakov <ap at webkit.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225374&action=review


> Websites/webkit.org/ChangeLog:14
> +	   without non-WebKit-style abbreviations and such. Use auto& instead
of const auto& in for loop
> +	   example, since that's normally preferred. Changed section title to
say "zero" instead of "0".

This is one part I'm not sure of. We have a lot of "const auto&" loop variables
currently in the tree, and I personally like those.


More information about the webkit-reviews mailing list