[webkit-reviews] review granted: [Bug 129467] Element::attributeChanged shouldn't do any work when attribute value didn't change : [Attachment 225438] Fixes the bug

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Ryosuke Niwa <rniwa at webkit.org>'s
request for review:
Bug 129467: Element::attributeChanged shouldn't do any work when attribute
value didn't change
https://bugs.webkit.org/show_bug.cgi?id=129467

Attachment 225438: Fixes the bug
https://bugs.webkit.org/attachment.cgi?id=225438&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225438&action=review


> Source/WebCore/dom/Attr.cpp:125
> +    AtomicString oldValue = this->value();

const AtomicString&

> Source/WebCore/dom/Attr.cpp:169
> +    AtomicString oldValue = value();

const AtomicString&

> Source/WebCore/dom/Element.cpp:1029
> +    AtomicString oldValue = attribute.value();

const AtomicString&

> Source/WebCore/dom/Element.cpp:1031
> +    QualifiedName attributeName = (!inSynchronizationOfLazyAttribute ||
valueChanged) ? attribute.name() : name;

const QualifiedName&

> Source/WebCore/dom/Element.cpp:1074
>      document().incDOMTreeVersion();
>  
> +    if (oldValue == newValue)
> +	   return;

Why do we incDOMTreeVersion unconditionally, even in the case where we're not
going to make a change?