[webkit-reviews] review granted: [Bug 129466] indexOf and lastIndexOf shouldn't resolve ropes when needle is longer than haystack : [Attachment 225434] Patch

[bugzilla-daemon at webkit.org]

Michael Saboff <msaboff at apple.com> has granted Ryosuke Niwa
<rniwa at webkit.org>'s request for review:
Bug 129466: indexOf and lastIndexOf shouldn't resolve ropes when needle is
longer than haystack
https://bugs.webkit.org/show_bug.cgi?id=129466

Attachment 225434: Patch
https://bugs.webkit.org/attachment.cgi?id=225434&action=review

------- Additional Comments from Michael Saboff <msaboff at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225434&action=review


r=me

> Source/JavaScriptCore/ChangeLog:8
> +	   Refactored the code to avoid calling toString on JSString when
needle is longer than haystack.

It is actually JSString::value that you are avoiding.