[webkit-reviews] review granted: [Bug 129464] Clean up Heap::collect and Heap::markRoots : [Attachment 225430] Patch

[bugzilla-daemon at webkit.org]

Geoffrey Garen <ggaren at apple.com> has granted Mark Hahnenberg
<mhahnenberg at apple.com>'s request for review:
Bug 129464: Clean up Heap::collect and Heap::markRoots
https://bugs.webkit.org/show_bug.cgi?id=129464

Attachment 225430: Patch
https://bugs.webkit.org/attachment.cgi?id=225430&action=review

------- Additional Comments from Geoffrey Garen <ggaren at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225430&action=review


r=me

> Source/JavaScriptCore/heap/Heap.cpp:483
> +void Heap::markProtectedObjects(HeapRootVisitor& heapRootVisitor)

"visit"?

> Source/JavaScriptCore/heap/Heap.cpp:493
> +void Heap::markTempSortVectors(HeapRootVisitor& heapRootVisitor)

"visit"?

> Source/JavaScriptCore/heap/Heap.cpp:513
> +void Heap::markArgumentBuffers(HeapRootVisitor& visitor)

"visit"?

> Source/JavaScriptCore/heap/Heap.cpp:637
> +    SamplingRegion samplingRegion("Garbage Collection: Tracing");

"Marking"?