[webkit-reviews] review granted: [Bug 129442] Updating some WebRTC and MediaStream LayoutTests : [Attachment 225402] Patch

[bugzilla-daemon at webkit.org]

Eric Carlson <eric.carlson at apple.com> has granted Thiago de Barros Lacerda
<thiago.lacerda at openbossa.org>'s request for review:
Bug 129442: Updating some WebRTC and MediaStream LayoutTests
https://bugs.webkit.org/show_bug.cgi?id=129442

Attachment 225402: Patch
https://bugs.webkit.org/attachment.cgi?id=225402&action=review

------- Additional Comments from Eric Carlson <eric.carlson at apple.com>
View in context: https://bugs.webkit.org/attachment.cgi?id=225402&action=review


> LayoutTests/fast/mediastream/RTCIceCandidate.html:-25
> -	       shouldNotThrow('initializer =
JSON.parse(JSON.stringify(candidate));');
> -
> -	       shouldNotThrow('candidate = new RTCIceCandidate(initializer);');

> -	       shouldBe('candidate.candidate', '"foo"');
> -	       shouldBe('candidate.sdpMid', '"bar"');
> -	       shouldBe('candidate.sdpMLineIndex', '6');
> -

ChangeLog should mention why this test was changed.

> LayoutTests/fast/mediastream/RTCSessionDescription.html:-24
> -	       shouldNotThrow('initializer =
JSON.parse(JSON.stringify(sessionDescription));');
> -
> -	       shouldNotThrow("sessionDescription = new
RTCSessionDescription(initializer);");
> -	       shouldBe('sessionDescription.type', '"offer"');
> -	       shouldBe('sessionDescription.sdp', '"foobar"');
> -

Ditto.