[webkit-reviews] review requested: [Bug 120185] Port to Geoclue2 : [Attachment 225392] Patch Proposal

[bugzilla-daemon at webkit.org]

Mario Sanchez Prada <mario at webkit.org> has asked  for review:
Bug 120185: Port to Geoclue2
https://bugs.webkit.org/show_bug.cgi?id=120185

Attachment 225392: Patch Proposal
https://bugs.webkit.org/attachment.cgi?id=225392&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
(In reply to comment #25)
> (In reply to comment #24)
> > Guys, I got :) Will try to do it as soon as possible - will try to find
sometime at the end of the week.
> 
> Any luck in finding time for this? We just merged controls for geolocation in
gnome-shell so now
> its even more important that at least all GNOME apps honor those preferences
by using geoclue2: 
>
https://raw.github.com/gnome-design-team/gnome-mockups/master/shell/system-menu
/system-status-menu-geolocation.png

As I mentioned yesterday on IRC, I agree with Anton to lend him a hand moving
this forward, as he's extremely busy these days with other matters and could
barely do it on time. So, I picked his patch, rebase it against master and did
a few changes (some of them following my own review) and I think I got now a
patch that could be a good option already for now since it works :), and adds
this as an optional thing (you need to pass --with-geoclue=2.0 at configure
time).

Please take a look to it and let me know what you think. I'll try to be as fast
and responsive to comments as possible during the following days.

Thanks!