[webkit-reviews] review granted: [Bug 115650] [GTK][WK2] Blocks when fetching plugins information : [Attachment 225356] Patch

[bugzilla-daemon at webkit.org]

Gustavo Noronha (kov) <gns at gnome.org> has granted Carlos Garcia Campos
<cgarcia at igalia.com>'s request for review:
Bug 115650: [GTK][WK2] Blocks when fetching plugins information
https://bugs.webkit.org/show_bug.cgi?id=115650

Attachment 225356: Patch
https://bugs.webkit.org/attachment.cgi?id=225356&action=review

------- Additional Comments from Gustavo Noronha (kov) <gns at gnome.org>
View in context: https://bugs.webkit.org/attachment.cgi?id=225356&action=review


LGTM!

> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:87
> +    g_file_set_contents(m_cachePath.get(), data.get(), dataLength, nullptr);


I guess we don't have to be concerned about multiple webkit clients trying to
write to the file at the same time since this is atomic, right?

> Source/WebKit2/UIProcess/Plugins/gtk/PluginInfoCache.cpp:135
> +    // Save the cache file in an idle to make sure it happens in the main
thread and
> +    // it's done only once when this is called multiple times in a very
short time.
> +    if (m_saveToFileIdleId)
> +	   return;

I assume this is called from a single thread, so we don't need to perform any
locking of the m_saveToFileIdleId member.