[webkit-reviews] review granted: [Bug 129403] speechSynthesis.speak of a zero length utterance kills future speech : [Attachment 225322] patch

bugzilla-daemon at webkit.org bugzilla-daemon at webkit.org
Thu Feb 27 02:24:37 PST 2014


Mario Sanchez Prada <mario at webkit.org> has granted chris fleizach
<cfleizach at apple.com>'s request for review:
Bug 129403: speechSynthesis.speak of a zero length utterance kills future
speech
https://bugs.webkit.org/show_bug.cgi?id=129403

Attachment 225322: patch
https://bugs.webkit.org/attachment.cgi?id=225322&action=review

------- Additional Comments from Mario Sanchez Prada <mario at webkit.org>
Looks good to me, hence the r+. Still, I wonder that the problem this is fixing
happens only for empty (zero-length) strings, or for anything that should not
spoken at all, such as a string containing only blanks or unpronounceable
characters. If that's the case, maybe it would make sense to check that in
advance and early return if needed.

What do you think?


More information about the webkit-reviews mailing list